Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

VB.Net: Strict Mode, fixes #32 #36

Merged
merged 4 commits into from
Apr 28, 2017
Merged

VB.Net: Strict Mode, fixes #32 #36

merged 4 commits into from
Apr 28, 2017

Conversation

wahmedswl
Copy link
Contributor

Hi, previous pull request wrongly assigned String to $GitIsDirty$ but it is Boolean. So sorry about that

@wahmedswl
fixes devlooped#32
4ab87dd 
VB.Net: Strict Mode, DataType need to be defined
@wahmedswl
$GitIsDirty$ is boolean, blindly used String
308b9c2
@kzu
Copy link
Member

kzu commented Apr 28, 2017

Could you rebase on top of master and resolve conflicts so I can merge?

Thanks!

@wahmedswl
Copy link
Contributor Author

@kzu, rebased. thanks

@kzu kzu merged commit f991bf7 into devlooped:master Apr 28, 2017
@kzu
Copy link
Member

kzu commented Apr 28, 2017

Thanks!

@wahmedswl
Copy link
Contributor Author

On Nuget, v1.1.56 is against this build? Is there any version mapping available?

Thanks

@devlooped devlooped locked and limited conversation to collaborators Sep 12, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@wahmedswl @kzu